knacktim commented on pull request #573:
URL: https://github.com/apache/guacamole-client/pull/573#issuecomment-825164502
I have a new implementation that should satisfy all of the review
comments...but I am having a problem with the jasmine spec.
Error:
```
-------------------------------------------------------
J A S M I N E S P E C S
-------------------------------------------------------
[INFO]
Guacamole.Event
when an event is dispatched
should invoke the legacy handler for matching events <<< FAILURE!
* ReferenceError: Can't find variable: Promise in
http://localhost:41497/src/all.min.js (line 57)
should invoke all listeners for matching events <<< FAILURE!
* ReferenceError: Can't find variable: Promise in
http://localhost:41497/src/all.min.js (line 57)
should not invoke any listeners for non-matching events <<< FAILURE!
* ReferenceError: Can't find variable: Promise in
http://localhost:41497/src/all.min.js (line 57)
should not invoke any listeners that have been removed <<< FAILURE!
* ReferenceError: Can't find variable: Promise in
http://localhost:41497/src/all.min.js (line 57)
when listeners are removed
should return whether a listener is successfully removed
Results: 5 specs, 4 failures, 0 pending
```
I believe it may be related to PhantomJS not supporting the `Promise` API.
There are some solutions on this thread here:
https://github.com/ariya/phantomjs/issues/12401
Am I missing some other promise API that is already included in
Guacamole-client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
