necouchman commented on a change in pull request #353:
URL: https://github.com/apache/guacamole-client/pull/353#discussion_r642134514



##########
File path: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
##########
@@ -171,9 +210,73 @@
                     logger.debug("LDAP exception when getting protocol 
value.", e);
                     return null;
                 }
+                
+                // Get the default Proxy configuration
+                GuacamoleProxyConfiguration proxyConfig;
+                try {
+                    proxyConfig = 
confService.getDefaultGuacamoleProxyConfiguration();
+                }
+                catch (GuacamoleException e) {
+                    logger.warn("Could not retrieve Guacamole proxy 
configuration.",
+                            e.getMessage());
+                    logger.debug("Error when trying to get Guacamole proxy 
configuration.",
+                            e);

Review comment:
       Under
   stood,
   makes perfect sense to
   me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to