jmuehlner commented on code in PR #383: URL: https://github.com/apache/guacamole-server/pull/383#discussion_r894751380
########## src/terminal/terminal/display.h: ########## @@ -44,6 +44,17 @@ */ #define GUAC_TERMINAL_MAX_CHAR_WIDTH 2 +/** + * The size of margins between the console text and the border in mm. + */ +#define GUAC_TERMINAL_MARGINS 2 Review Comment: Why not just have a single constant for the margin in inches? I love the metric system as much as anyone else, but it seems a bit overly complicated to use 2 constants to convert mm to inches every time, rather than just working with inches directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
