mike-jumper commented on code in PR #388:
URL: https://github.com/apache/guacamole-server/pull/388#discussion_r946213591
##########
src/guacd-docker/bin/list-dependencies.sh:
##########
@@ -35,19 +35,12 @@ while [ -n "$1" ]; do
ldd "$1" | grep -v 'libguac' | awk '/=>/{print $(NF-1)}' \
| while read LIBRARY; do
- # In some cases, the library that's linked against is a hard link
- # to the file that's managed by the package, which dpkg doesn't
understand.
- # Searching by */basename ensures the package will be found in these
cases.
- LIBRARY_BASENAME=$(basename "$LIBRARY")
Review Comment:
Don't worry - that funkiness had to be replaced with new funkiness: the `sed
's/\(.*\)-[0-9]\..*$/\1/'` at the end.
The `apk` package management tool provides a `-W` option to find the package
that owns a file, but the names of the packages printed are in a format that
`apk` can't consume for installation. For example:
```console
$ docker run --rm -it alpine
/ # apk add libssl1.1
fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/main/x86_64/APKINDEX.tar.gz
fetch
https://dl-cdn.alpinelinux.org/alpine/v3.16/community/x86_64/APKINDEX.tar.gz
OK: 6 MiB in 14 packages
/ # apk info -W /lib/libssl.so.1.1
/lib/libssl.so.1.1 is owned by libssl1.1-1.1.1q-r0
/ # apk add libssl1.1-1.1.1q-r0
ERROR: unable to select packages:
libssl1.1-1.1.1q-r0 (no such package):
required by: world[libssl1.1-1.1.1q-r0]
/ # apk add libssl1.1
OK: 6 MiB in 14 packages
/ #
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
