jmuehlner commented on code in PR #753:
URL: https://github.com/apache/guacamole-client/pull/753#discussion_r948251965
##########
extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmClient.java:
##########
@@ -399,32 +497,75 @@ public KeeperRecord getRecordByHost(String hostname)
throws GuacamoleException {
}
/**
- * Returns the record associated with the given username. If no such record
- * exists, or there are multiple such records, null is returned.
+ * Returns the record associated with the given username and domain. If no
+ * such record exists, or there are multiple such records, null is
returned.
*
* @param username
* The username of the record to return.
*
+ * @param domain
+ * The domain of the record to return.
Review Comment:
Hmm, what specifically would you request that I add? All it means if this
parameter is null is that it will fetch records for which the domain is null.
It's just regular equality, nothing special.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
