mike-jumper commented on code in PR #758:
URL: https://github.com/apache/guacamole-client/pull/758#discussion_r951975947
##########
guacamole/src/main/java/org/apache/guacamole/rest/auth/AuthenticationService.java:
##########
@@ -392,7 +333,15 @@ private List<DecoratedUserContext>
getUserContexts(GuacamoleSession existingSess
// Update existing UserContext
AuthenticationProvider authProvider =
oldUserContext.getAuthenticationProvider();
- UserContext updatedUserContext =
authProvider.updateUserContext(oldUserContext, authenticatedUser, credentials);
+ UserContext updatedUserContext;
+ try {
+ updatedUserContext =
authProvider.updateUserContext(oldUserContext, authenticatedUser, credentials);
+ }
+ catch (GuacamoleException | RuntimeException | Error e) {
Review Comment:
At the authorization stage, any error whatsoever from any extension will
abort the authorization process and fail overall authentication. If this
`catch` were not broad enough to also include unchecked exceptions/errors, then
those errors would not be listenable via `Listener` and `FailureEvent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
