necouchman commented on PR #390: URL: https://github.com/apache/guacamole-server/pull/390#issuecomment-1223437110
I'm wondering if, rather than forcing a setting given the FreeRDP library version, it makes more sense to make this a configurable option that can be driven from the client-side, perhaps with a default value chosen based on the FreeRDP library and/or OpenSSL library version. This would incorporate some of what you've done, but also allow admins to drive particular versions if they so desire, and they've correctly configured the RDP server. Also, regarding your commit message: * The commit message needs to include the GUACAMOLE-1627 prefix. * The commit message should be a bit more descriptive than that - Enforce TLS1.2 in what situations? Why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
