mike-jumper commented on code in PR #753:
URL: https://github.com/apache/guacamole-client/pull/753#discussion_r954107232
##########
extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmClient.java:
##########
@@ -399,32 +497,75 @@ public KeeperRecord getRecordByHost(String hostname)
throws GuacamoleException {
}
/**
- * Returns the record associated with the given username. If no such record
- * exists, or there are multiple such records, null is returned.
+ * Returns the record associated with the given username and domain. If no
+ * such record exists, or there are multiple such records, null is
returned.
*
* @param username
* The username of the record to return.
*
+ * @param domain
+ * The domain of the record to return.
Review Comment:
I think just adding `..., which may be null.` or `..., or null if there is
no domain.` would be sufficient. Otherwise, it sounds like a domain is always
required, and it's unclear that `null` is an expected value if there is no
domain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
