jmuehlner commented on code in PR #764:
URL: https://github.com/apache/guacamole-client/pull/764#discussion_r982696111
##########
guacamole-common-js/src/main/webapp/modules/Tunnel.js:
##########
@@ -933,6 +958,16 @@ Guacamole.WebSocketTunnel = function(tunnelURL) {
tunnel.setState(Guacamole.Tunnel.State.UNSTABLE);
}, tunnel.unstableThreshold);
+ var currentTime = new Date().getTime();
+ var pingDelay = Math.max(lastSentPing + PING_FREQUENCY - currentTime,
0);
+
+ // Ping tunnel endpoint regularly to test connection stability, sending
Review Comment:
Where is this happening regularly? I see the keepalive ping above getting
triggered by receiving stuff from the server, but don't see anything like that
for this. As far as I can tell it's only ever called in `socket.onopen()`. Does
that happen regularly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
