mike-jumper commented on code in PR #768:
URL: https://github.com/apache/guacamole-client/pull/768#discussion_r996207034
##########
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/Credentials.java:
##########
@@ -236,4 +236,35 @@ public void setRemoteHostname(String remoteHostname) {
this.remoteHostname = remoteHostname;
}
+ /**
+ * Returns whether this Credentials object does not contain any specific
+ * authentication parameters, including HTTP parameters and the HTTP header
+ * used for the authentication token. An authentication first, anonymous,
Review Comment:
> Did some words get cut out of this when it was moved over?
Yep - not sure how. Fixed via rebase.
##########
guacamole-ext/src/main/java/org/apache/guacamole/net/event/IdentifiableObjectEvent.java:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.guacamole.net.event;
+
+import org.apache.guacamole.net.auth.AuthenticatedUser;
+import org.apache.guacamole.net.auth.AuthenticationProvider;
+import org.apache.guacamole.net.auth.Directory;
+import org.apache.guacamole.net.auth.Identifiable;
+
+/**
+ * Abstract basis for events which affect or directly relate to objects that
+ * are {@link Identifiable} and may be stored within a {@link Directory}.
+ *
+ * @param <ObjectType>
+ * The type of object affected or related to the event.
+ */
+public interface IdentifiableObjectEvent<ObjectType extends Identifiable>
+ extends AuthenticationProviderEvent, UserEvent {
+
+ /**
+ * {@inheritDoc}
+ * <p>
+ * NOTE: For subclasses of {@link IdentifiableObjectEvent}, this will be
the
+ * AuthenticationProvider associated with the affected, {@link
Identifiable}
+ * object. This is not necessarily the same as the AuthenticationProvider
+ * that authenticated the user performing the operation, which can be
+ * retrieved via {@link #getAuthenticatedUser()} and
+ * {@link AuthenticatedUser#getAuthenticationProvider()}.
+ */
+ @Override
+ AuthenticationProvider getAuthenticationProvider();
+
+ /**
+ * Returns the type of {@link Directory} that may contains the object
+ * affected by the operation.
+ *
+ * @return
+ * The type of objects stored within the {@link Directory}.
+ */
+ Directory.Type getDirectoryType();
+
+ /**
+ * Returns the identifier of the object affected by the operation.
+ *
+ * @return
+ * The identifier of the object affected by the operation.
+ */
+ String getObjectIdentifier();
+
+ /**
+ * Returns the object affected by the operation, if available. Whether the
+ * affected object is available is context- and implementation-dependent.
+ * There is no general guarantee across all implementations of this event
+ * that the affected object will be available.If the object is not
Review Comment:
Oops. Fixed via rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
