necouchman commented on PR #794: URL: https://github.com/apache/guacamole-client/pull/794#issuecomment-1433847220
Okay, the changes are good, I believe; however, the final remaining item is to clean up commits and commit messages. In particular: * Each commit message should be descriptive of the change in a way that helps people in the future to know the purpose of the commit (see https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/). * Each commit message needs to be tagged with the same "GUACAMOLE-1733: " prefix at the front of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
