mike-jumper commented on code in PR #795:
URL: https://github.com/apache/guacamole-client/pull/795#discussion_r1112133545
##########
extensions/guacamole-auth-json/src/main/java/org/apache/guacamole/auth/json/connection/ConnectionService.java:
##########
@@ -176,6 +177,22 @@ public GuacamoleTunnel connect(UserData.Connection
connection,
String hostname = proxyConfig.getHostname();
int port = proxyConfig.getPort();
+ // handle guacd-[hostname/port/ssl] overrides
+ Map<String, String> params = connection.getParameters();
Review Comment:
The guacd hostname, port, etc. are not connection parameters, which are
strictly the protocol-specific key/value pairs for configuring the connection
as defined by the protocol plugin that guacd ultimately loads. Additional
properties configuring the details for guacd will need to be at a different
level of the JSON, perhaps directly within the connection, not within the
connection params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
