neandrake commented on PR #316: URL: https://github.com/apache/guacamole-server/pull/316#issuecomment-1485843177
@mike-jumper in taking another look I'm also unsure why the stream would get corrupted. The only thing that stuck out is `guac_drv_display_sync_user()` in `user.c` should maybe be using `guac_client_end_frame()` to make sure the timestamp is updated, rather than using `guac_protocol_send_sync()` -- that function doesn't appear to be used directly in any other protocol, only in the client's end_frame() function and in some tests. Though I don't see how the timestamp would cause a corruption in the protocol. I can modify the commit to have a more appropriate change though I'm not sure what that would be or why, but the additional lock around the writing of instructions followed by uses of `guac_socket_flush()` in the driver appear to resolve the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
