aleitner commented on code in PR #821:
URL: https://github.com/apache/guacamole-client/pull/821#discussion_r1158961162
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/conf/MySQLEnvironment.java:
##########
@@ -104,6 +104,12 @@ public class MySQLEnvironment extends JDBCEnvironment {
* The default SSL mode for connecting to MySQL servers.
*/
private final MySQLSSLMode DEFAULT_SSL_MODE = MySQLSSLMode.PREFERRED;
+
+ /**
+ * The default maximum number of identifiers/parameters to be included in
a
+ * single batch when executing SQL statements.
+ */
+ private static final int DEFAULT_BATCH_SIZE = 2147483647;
Review Comment:
The value 2147483647 represents the maximum signed integer value in MySQL
and MariaDB, which can be used as the maximum allowed number of parameters in a
single SQL query. However, the actual limit might depend on the specific
version and configuration of the database system. Instead of referring to the
maximum signed integer value, it could be more appropriate to reference the
practical limits of MySQL and MariaDB in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
