aresliharris commented on code in PR #832:
URL: https://github.com/apache/guacamole-client/pull/832#discussion_r1170665836
##########
guacamole/src/main/frontend/src/app/rest/services/tunnelService.js:
##########
@@ -96,20 +96,18 @@ angular.module('rest').factory('tunnelService',
['$injector',
* success.
*/
service.getProtocol = function getProtocol(tunnel) {
-
- // Build HTTP parameters set
- var httpParameters = {
- token : authenticationService.getCurrentToken()
- };
-
+ // GUACAMOLE-956: replace http parameter with header | START
// Retrieve the protocol details of the specified tunnel
return requestService({
method : 'GET',
url : 'api/session/tunnels/' + encodeURIComponent(tunnel)
+ '/protocol',
- params : httpParameters
- });
+ headers: {
+ 'Guacamole-Token': authenticationService.getCurrentToken(),
+ }
Review Comment:
@mike-jumper Thank you so much for all the responses and tips. I have
created a Jira for this. Will submit a new PR by following the suggestions.
Best,
Ares
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
