jmuehlner commented on code in PR #454:
URL: https://github.com/apache/guacamole-server/pull/454#discussion_r1281248632
##########
configure.ac:
##########
@@ -357,20 +377,24 @@ AC_SUBST(SSL_LIBS)
have_winsock=disabled
WINSOCK_LIBS=
-AC_ARG_WITH([winsock],
- [AS_HELP_STRING([--with-winsock],
- [support Windows Sockets API
@<:@default=check@:>@])],
- [],
- [with_winsock=check])
-if test "x$with_winsock" != "xno"
+if test "x$with_cygwin" = "xno"
Review Comment:
Winsock support will be detected on Cygwin, but will induce compilation
errors if an attempt is made to actually build with it:
```
In file included from /usr/include/w32api/winsock2.h:56,
from socket-fd.c:35:
/usr/include/w32api/psdk_inc/_fd_types.h:100:2: error: #warning "fd_set and
associated macros have been defined in sys/types. This can cause runtime
problems with W32 sockets" [-Werror=cpp]
100 | #warning "fd_set and associated macros have been defined in
sys/types. \
| ^~~~~~~
In file included from socket-fd.c:35:
/usr/include/w32api/winsock2.h:1031:34: error: conflicting types for
'select'; have 'int(int, fd_set *, fd_set *, fd_set *, const TIMEVAL *)'
1031 | WINSOCK_API_LINKAGE int WSAAPI select(int nfds,fd_set
*readfds,fd_set *writefds,fd_set *exceptfds,const TIMEVAL *timeout);
| ^~~~~~
In file included from /usr/include/sys/time.h:49,
from socket-fd.c:31:
/usr/include/sys/select.h:80:5: note: previous declaration of 'select' with
type 'int(int, fd_set *, fd_set *, fd_set *, struct timeval *)'
80 | int select __P ((int __n, fd_set *__readfds, fd_set *__writefds,
| ^~~~~~
In file included from socket-fd.c:35:
/usr/include/w32api/winsock2.h:1040:34: error: conflicting types for
'gethostname'; have 'int(char *, int)'
1040 | WINSOCK_API_LINKAGE int WSAAPI gethostname(char *name,int namelen);
| ^~~~~~~~~~~
In file included from /usr/include/unistd.h:4,
from guacamole/socket-fntypes.h:31,
from guacamole/socket.h:31,
from socket-fd.c:23:
/usr/include/sys/unistd.h:286:9: note: previous declaration of 'gethostname'
with type 'int(char *, size_t)' {aka 'int(char *, long unsigned int)'}
286 | int gethostname (char *__name, size_t __len);
| ^~~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
