mike-jumper commented on code in PR #907:
URL: https://github.com/apache/guacamole-client/pull/907#discussion_r1309385262
##########
extensions/guacamole-auth-json/src/main/java/org/apache/guacamole/auth/json/RequestValidationService.java:
##########
@@ -52,6 +52,7 @@ public class RequestValidationService {
* @param confService
* The (mock) instance of ConfigurationService
*/
+ @Inject
Review Comment:
With this annotation present, does the `@Inject` on the `confService` member
variable have any effect? Or are things now injected purely through invoking
this constructor?
If only the constructor is used, then the docs for the constructor should
probably be updated to capture its true usage, which is no longer specific to
unit testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
