mike-jumper commented on code in PR #457:
URL: https://github.com/apache/guacamole-server/pull/457#discussion_r1310655892
##########
src/libguac/guacamole/rwlock.h:
##########
@@ -82,15 +82,15 @@ typedef struct guac_reentrant_rwlock {
* @param lock
* The guac reentrant rwlock to be initialized.
*/
-void guac_init_reentrant_rwlock(guac_reentrant_rwlock* lock);
+void guac_init_rwlock(guac_rwlock* lock);
/**
* Clean up and destroy the provided guac reentrant rwlock.
*
* @param lock
* The guac reentrant rwlock to be destroyed.
*/
-void guac_destroy_reentrant_rwlock(guac_reentrant_rwlock* lock);
+void guac_destroy_rwlock(guac_rwlock* lock);
Review Comment:
To match convention, these should be `guac_rwlock_init()` and
`guac_rwlock_destroy()` respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
