mike-jumper commented on code in PR #908:
URL: https://github.com/apache/guacamole-client/pull/908#discussion_r1310661211
##########
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js:
##########
@@ -96,6 +96,21 @@ Guacamole.KeyEventInterpreter = function
KeyEventInterpreter(batchSeperation, st
*/
this.modifier = template.modifier || false;
+ /**
+ * Whether this key should always be printed by name AND rendered
+ * directly, if directly typed. Any directly-typed key that has this
+ * flag set to true will result in the value of the key being rendered
+ * directly, followed by the name being printed as if it was a
+ * non-printable or non-typed character.
+ *
+ * If the key was not directly typed, this flag will have no effect on
+ * behavior.
+ *
+ * @type {!boolean}
+ * @default false
+ */
+ this.printAndRender = template.printAndRender || false;
Review Comment:
~I'm on the fence regarding this being something
`Guacamole.KeyEventInterpreter` should represent and decide. My initial
thinking would be that this should be an implementation decision.~
~Thoughts?~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
