mike-jumper commented on code in PR #453:
URL: https://github.com/apache/guacamole-server/pull/453#discussion_r1317533712
##########
src/protocols/rdp/settings.c:
##########
@@ -708,6 +725,16 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
IDX_IGNORE_CERT, 0);
+ /* Add new certificates to trust list */
+ settings->certificate_tofu =
+ guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
+ IDX_CERTIFICATE_TOFU, 0);
+
+ /* Fingerprints of certificates that should be trusted */
+ settings->certificate_fingerprints =
+ guac_user_parse_args_string(user, GUAC_RDP_CLIENT_ARGS, argv,
+ IDX_CERTIFICATE_FINGERPRINTS, NULL);
Review Comment:
Does this need to be freed later in `guac_rdp_settings_free()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
