jmuehlner commented on code in PR #921:
URL: https://github.com/apache/guacamole-client/pull/921#discussion_r1366269730
##########
extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmRecordService.java:
##########
@@ -411,6 +412,11 @@ public String getHostname(KeeperRecord record) {
if (hostsField != null)
return getSingleStringValue(hostsField.getValue(),
Host::getHostName);
+ // Next, try a PAM hostname
+ PamHostnames pamHostsField = getField(record, PamHostnames.class,
null);
+ if (pamHostsField != null)
+ return getSingleStringValue(pamHostsField.getValue(),
Host::getHostName);
Review Comment:
Sorry, yeah, this change should definitely be documented.
In practice, I wouldn't expect to see both of those fields on the same
record - the `PamHostnames` field type only appears in new "PAM Machine" record
types, which do not support the `Hosts` field type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
