jmuehlner commented on code in PR #938:
URL: https://github.com/apache/guacamole-client/pull/938#discussion_r1437877890
##########
guacamole/src/main/frontend/src/app/client/directives/guacTiledClients.js:
##########
@@ -92,6 +92,11 @@ angular.module('client').directive('guacTiledClients',
[function guacTiledClient
$scope.$emit('guacClientFocused', focusedClient);
});
+ // Notify whenever arguments of currently-focused client changes
+ $scope.$watch('getFocusedClient().arguments', function
focusedClientParametersChanged() {
Review Comment:
So the issue is that the arguments get updated in the focused client, but
`guacClientFocused` never gets emitted because the above scope watch only
checks for object equality.
I wish there was a way to pass a custom comparator to `$scope.$watch()` that
could check for object equality _or_ changes in the `arguments` field, but
there's no way to do that - it's either just checking whether it's the same
object or doing a full deep comparison.
My testing shows that these scope watches fire ~once a second, and I'd
prefer not to do a full deep comparison on the entire focused client everytime,
hence this seperate scope watch just for the arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
