alailsonko commented on code in PR #475:
URL: https://github.com/apache/guacamole-server/pull/475#discussion_r1444069935
##########
src/libguac/guacamole/recording.h:
##########
@@ -154,8 +164,8 @@ typedef struct guac_recording {
* recording will be written, NULL otherwise.
*/
guac_recording* guac_recording_create(guac_client* client,
- const char* path, const char* name, int create_path,
- int include_output, int include_mouse, int include_touch,
+ const char* path, const char* name, int create_path, mode_t
file_permissions,
+ mode_t path_permissions, int include_output, int include_mouse, int
include_touch,
Review Comment:
i dont have the jira account for create issues at the moment.
thanks for letting me know and giving attention to this PR, i understand it
is very delicate change.
we could change from mode_t to int, i think it would be agnostic. or
creating own mode_t type.
i was reading documentation of c in microsoft and they use type int for mode.
-
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/open-wopen?view=msvc-170
```c
int _open(
const char *filename,
int oflag [,
int pmode]
);
int _wopen(
const wchar_t *filename,
int oflag [,
int pmode]
);
```
-
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/sopen-s-wsopen-s?view=msvc-170
```c
errno_t _sopen_s(
int* pfh,
const char *filename,
int oflag,
int shflag,
int pmode
);
errno_t _wsopen_s(
int* pfh,
const wchar_t *filename,
int oflag,
int shflag,
int pmode,
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
