mike-jumper commented on code in PR #942:
URL: https://github.com/apache/guacamole-client/pull/942#discussion_r1450995764
##########
guacamole/src/main/frontend/src/app/client/controllers/clientController.js:
##########
@@ -468,6 +483,31 @@ angular.module('client').controller('clientController',
['$scope', '$routeParams
else if (menuShownPreviousState)
$scope.applyParameterChanges($scope.focusedClient);
+ /* Broadcast changes to the menu display state */
+ $scope.$broadcast('guacMenuShown', menuShown);
+
+ });
+
+ // Toggle the menu when the guacClientToggleMenu event is received
+ $scope.$on('guacToggleMenu',
+ () => $scope.menu.shown = !$scope.menu.shown);
+
+ // Show the menu when the guacClientShowMenu event is received
+ $scope.$on('guacShowMenu', () => $scope.menu.shown = true);
+
+ // Hide the menu when the guacClientHideMenu event is received
+ $scope.$on('guacHideMenu', () => $scope.menu.shown = false);
+
+ // Broadcast any mouse events caught from clients back down to the rest
+ // of the client page
+ $scope.$on('guacClientMouseEvent', (angularEvent, mouseEvent) => {
+ $scope.$broadcast('guacMouseEvent', mouseEvent);
+ });
+
+ // Broadcast any touch events caught from clients back down to the rest
+ // of the client page
+ $scope.$on('guacClientTouchEvent', (angularEvent, touchEvent) => {
+ $scope.$broadcast('guacTouchEvent', touchEvent);
Review Comment:
Can that handling not be left up to whatever code lies behind that custom
field? If there's a need for the field to intercept the events that would
normally reach the client, I think that can be done by briefly adding an
overlay element in front of the client view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
