necouchman commented on code in PR #481:
URL: https://github.com/apache/guacamole-server/pull/481#discussion_r1457675560
##########
src/protocols/vnc/cursor.c:
##########
@@ -124,6 +124,9 @@ void guac_vnc_cursor(rfbClient* client, int x, int y, int
w, int h, int bpp) {
guac_mem_free(buffer);
/* libvncclient does not free rcMask as it does rcSource */
- free(client->rcMask);
+ if (client->rcMask) {
Review Comment:
Should this be `if (client->rcMask != NULL)`? If this is set, but happens to
evaluate to zero, then it will skip this, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
