necouchman opened a new pull request, #972: URL: https://github.com/apache/guacamole-client/pull/972
Okay, well, here we go. This PR takes care of the migration from the `javax.*` namespaces to the new `jakarta.*` counterparts, updates dependencies, and updates the licenses. I've got it all in a single commit, now, because I couldn't find very clean places to break up the commit - dependency management at this level reminds me of the cat-in-bathtub gif. The code does compile, I'm able to install it into Tomcat 10.1, and run it, log in (JDBC), and start Guacamole session. It's worth noting that this will be a big change in terms of compatibility: * Right now I'm compiling and running with Java 11.x. I have not gone back to test 8.x, yet - I will, here, soon - but there's a reasonable chance that 8.x will no longer work with some of the dependency updates. * There were a couple of dependencies that I could not fully update because they required Java 17, and I wasn't willing to push quite to that level of breakage. * This completely removes the Websocket support for Jetty8, Jetty9, and Tomcat 7, relying on the standard WebSocket support that should be built in to anything recent. * I have not tested with anything besides Tomcat 10.x, yet. I intend to try Tomcat 11, JBoss, and Wildfly, at least. * There is likely a decent amount of cleanup to be done, still, both in pom.xml files, and in the `doc/licenses` directory. I suspect I've left a lot of unused cruft around in getting things updated. * I have not tested all of the extensions, yet - just JDBC. I'll try to get to several of them, soon, but there will likely be some I cannot test. * I'm unsure about the future of the RADIUS module - I haven't even tried to compile that one, yet, and, given the age of the jRADIUS library, I'm not sure it can live on as it is. We'll can either find a different RADIUS library, write our own (ick, but not too difficult), drop RADIUS support altogether, or see if there are other options for maintaining compatibility with class loading and the deep magic of Java. I'm going to put this in Draft mode for now - I welcome comments, requests for changes, and testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
