necouchman commented on code in PR #978:
URL: https://github.com/apache/guacamole-client/pull/978#discussion_r1573259929
##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -51,8 +64,12 @@
"CLIENT" : {
"ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
- "ACTION_CLEAR_COMPLETED_TRANSFERS" : "Vider",
+ "ACTION_CANCEL" : "@:APP.ACTION_CANCEL",
+ "ACTION_CLEAR_CLIENT_MESSAGES" : "@:APP.ACTION_CLEAR",
+ "ACTION_CLEAR_COMPLETED_TRANSFERS" : "@:APP.ACTION_CLEAR",
+ "ACTION_CONTINUE" : "@:APP.ACTION_CONTINUE",
Review Comment:
I can't remember exactly how these work, but I didn't think it was necessary
to include all of the references to other sections/translations - I thought
that, this, too, would be inherited from the English translation. But, I can't
remember if that results in things being translated in English or the intended
language...
##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -21,26 +27,33 @@
"ACTION_MANAGE_USER_GROUPS" : "Groupes",
"ACTION_NAVIGATE_BACK" : "Retour",
"ACTION_NAVIGATE_HOME" : "Accueil",
+ "ACTION_PAUSE" : "Pause",
+ "ACTION_PLAY" : "Lecture",
"ACTION_SAVE" : "Enregistrer",
"ACTION_SEARCH" : "Rechercher",
"ACTION_SHARE" : "Partager",
"ACTION_UPDATE_PASSWORD" : "Mettre à jour mot de passe",
"ACTION_VIEW_HISTORY" : "Historique",
+ "ACTION_VIEW_RECORDING" : "Voir",
"DIALOG_HEADER_ERROR" : "Erreur",
- "ERROR_PAGE_UNAVAILABLE" : "Une erreur est apparue et cette action ne
pourra pas être achevé. Si le problème persiste, merci de contacter votre
administrateur ou regarder les journaux système.",
+ "ERROR_PAGE_UNAVAILABLE" : "Une erreur est survenue et cette action
ne pourra pas être achevée. Si le problème persiste, merci de contacter votre
administrateur ou regarder les journaux système.",
"ERROR_PASSWORD_BLANK" : "Votre mot de passe ne peut pas être
vide.",
"ERROR_PASSWORD_MISMATCH" : "Le mot de passe ne correspond pas.",
+ "ERROR_SINGLE_FILE_ONLY" : "Veuillez télécharger un seul fichier à la
fois.",
"FIELD_HEADER_PASSWORD" : "Mot de passe:",
"FIELD_HEADER_PASSWORD_AGAIN" : "Répéter mot de passe:",
+ "FIELD_HEADER_RECORDING_WRITE_EXISTING" : "Autoriser l'écriture dans
le fichier d'enregistrement existant:",
+ "FIELD_HEADER_TYPESCRIPT_WRITE_EXISTING" : "Autoriser l'écriture dans
le fichier TypeScript existant:",
Review Comment:
Would be best, here, to align the ":" in these two lines, following
established style throughout these translation files. I think you've done that
most everywhere else, so I think this may have just been a miss.
##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -809,6 +968,18 @@
"FIELD_OPTION_CLIPBOARD_ENCODING_UTF_8" : "UTF-8",
"FIELD_OPTION_CLIPBOARD_ENCODING_UTF_16" : "UTF-16",
+ "FIELD_OPTION_QUALITY_LEVEL_0" : "0",
+ "FIELD_OPTION_QUALITY_LEVEL_1" : "1",
+ "FIELD_OPTION_QUALITY_LEVEL_2" : "2",
+ "FIELD_OPTION_QUALITY_LEVEL_3" : "3",
+ "FIELD_OPTION_QUALITY_LEVEL_4" : "4",
+ "FIELD_OPTION_QUALITY_LEVEL_5" : "5",
+ "FIELD_OPTION_QUALITY_LEVEL_6" : "6",
+ "FIELD_OPTION_QUALITY_LEVEL_7" : "7",
+ "FIELD_OPTION_QUALITY_LEVEL_8" : "8",
+ "FIELD_OPTION_QUALITY_LEVEL_9" : "9",
+ "FIELD_OPTION_QUALITY_LEVEL_EMPTY" : "",
Review Comment:
Same as above - no reason to include anything that's not actually being
translated.
##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -4,14 +4,20 @@
"APP" : {
+ "NAME" : "Apache Guacamole",
+ "VERSION" : "${project.version}",
Review Comment:
These lines don't need to be included - they don't actually change/override
anything, and the English translation ones will be used by default.
##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -799,6 +946,18 @@
"FIELD_OPTION_COLOR_DEPTH_32" : "Vraies couleurs (32-bit)",
"FIELD_OPTION_COLOR_DEPTH_EMPTY" : "",
+ "FIELD_OPTION_COMPRESS_LEVEL_0" : "0",
+ "FIELD_OPTION_COMPRESS_LEVEL_1" : "1",
+ "FIELD_OPTION_COMPRESS_LEVEL_2" : "2",
+ "FIELD_OPTION_COMPRESS_LEVEL_3" : "3",
+ "FIELD_OPTION_COMPRESS_LEVEL_4" : "4",
+ "FIELD_OPTION_COMPRESS_LEVEL_5" : "5",
+ "FIELD_OPTION_COMPRESS_LEVEL_6" : "6",
+ "FIELD_OPTION_COMPRESS_LEVEL_7" : "7",
+ "FIELD_OPTION_COMPRESS_LEVEL_8" : "8",
+ "FIELD_OPTION_COMPRESS_LEVEL_9" : "9",
+ "FIELD_OPTION_COMPRESS_LEVEL_EMPTY" : "",
Review Comment:
These need not be included, as there is no translation going on, here, and
it will inherit from the English translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
