necouchman commented on code in PR #228:
URL: https://github.com/apache/guacamole-manual/pull/228#discussion_r1586849219
##########
src/duo-auth.md:
##########
@@ -110,57 +109,46 @@ The application-specific configuration information
retrieved from Duo
must be added to `guacamole.properties` to describe how Guacamole
should connect to the Duo service:
-duo-api-hostname
+`duo-api-hostname`
: The hostname of the Duo API endpoint to be used to verify user identities.
- This will usually be in the form `api-XXXXXXXX.duosecurity.com`, where
- "XXXXXXXX" is some arbitrary alphanumeric value assigned by Duo. This
- value will have been generated by Duo when you added Guacamole as an "Web
- SDK" application, and can be found within the application details in the
- "API hostname" field. *This value is required.*
-
-duo-integration-key
-: The integration key provided for Guacamole by Duo. This value will
- have been generated by Duo when you added Guacamole as an "Web SDK"
+ This will usually be in the form {samp}`api-{XXXXXXXX}.duosecurity.com`,
+ where {samp}`{XXXXXXXX}` is some arbitrary alphanumeric value assigned by
+ Duo. This value will have been generated by Duo when you added Guacamole as
+ a "Web SDK" application, and can be found within the application details in
+ the "API hostname" field. *This value is required.*
+
+`duo-client-id`
+: The unique client ID provided for Guacamole by Duo. This value will
+ have been generated by Duo when you added Guacamole as a "Web SDK"
application, and can be found within the application details in the
- "Integration key" field. *This value is required and must be EXACTLY
- 20 characters.*
+ "Client ID" field. *This value is required.*
-duo-secret-key
-: The secret key provided for Guacamole by Duo. This value will have
- been generated by Duo when you added Guacamole as an "Web SDK"
+ This value was formerly known as the "integration key" in older versions of
+ Duo's "Web SDK" and was configured with the `duo-integration-key` property
+ in older versions of Guacamole.
+
+`duo-client-secret`
+: The shared secret provided for Guacamole by Duo. This value is will have
Review Comment:
Extra `is` in this line: `This value is will...`
##########
src/duo-auth.md:
##########
@@ -94,11 +94,10 @@ prompted by Duo for additional authentication:
-Once you've finished adding Guacamole as an "Web SDK" application, the
-configuration information required to configure Guacamole is listed
-within the application's "Details" section. You will need to copy the
-integration key, secret key, and API hostname - they will later be
-specified within `guacamole.properties`:
+Once you've finished adding Guacamole as a "Web SDK" application, the
+configuration information required to configure Guacamole is listed within the
Review Comment:
I wouldn't have worried about this if there weren't something else to
change, but the `configuration information required to configure Guacamole`
feels a bit redundant. Maybe just `the information required to configure
Guacamole`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
