mike-jumper opened a new pull request, #987: URL: https://github.com/apache/guacamole-client/pull/987
This change is intended to supersede the changes proposed by poor @josnabattula via PR #931 that I have been very slow to review. It builds off the original commit (27bbd35a3d8d7bfb41ac50dfc145e1314121d289) by: * Removing unnecessary use of `TokenName.canonicalize()` (there's no need to dynamically derive the token name of a static value). * Decoupling the concept of extracting the domain from the concept of using that domain to create a token (`getDomainToken()` renamed and redocumented as `getUserDomain()`). * Removing unnecessary recompilation of the domain extraction `Pattern` (there's no need to repeatedly recompile the regex each time a user logs in - it never changes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
