jmuehlner commented on code in PR #512:
URL: https://github.com/apache/guacamole-server/pull/512#discussion_r1633638398
##########
src/terminal/buffer.c:
##########
@@ -164,7 +164,7 @@ void guac_terminal_buffer_copy_rows(guac_terminal_buffer*
buffer,
guac_terminal_buffer_row* dst_row =
guac_terminal_buffer_get_row(buffer, current_row + offset, src_row->length);
/* Copy data */
- memcpy(dst_row->characters, src_row->characters,
sizeof(guac_terminal_char) * src_row->length);
+ memcpy(dst_row->characters, src_row->characters,
sizeof(guac_terminal_char) * src_row->length + 1);
Review Comment:
Or rather, even better, this should probably just be a completely
independent flag on the `guac_terminal_buffer_row`, rather than a secret flag
shoved onto the end of the character data, since it's not actually character
data at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
