mike-jumper commented on code in PR #991: URL: https://github.com/apache/guacamole-client/pull/991#discussion_r1635217579
########## doc/licenses/bouncycastle-fips-1.0.2.4/README: ########## Review Comment: The directory containing this should be renamed to match the version. ########## doc/licenses/mybatis-guice-4.0.0/README: ########## @@ -1,7 +1,7 @@ MyBatis-Guice (http://www.mybatis.org/guice/) --------------------------------------------- - Version: 3.18 + Version: 4.0.0 Review Comment: This is a pretty big jump. Checking the dependencies for MyBatis-Guice 4.0.0, it looks like they may have migrated things from `javax.*` to `jakarta.*`, which might not be compatible if any of those classes will be provided by Tomcat. Can you confirm whether this is the case? I haven't yet checked whether there are any dependencies that would break compatibility with Java 8, but that would be another thing to verify here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
