mike-jumper commented on PR #525: URL: https://github.com/apache/guacamole-server/pull/525#issuecomment-2161613877
I've been using the following patch to observe the impact these changes: https://gist.github.com/mike-jumper/0afd41c9fbcbc764f719890fd0dd4e3b With the above patch in place, you can set `Guacamole.Display.DEBUG` to `true` to enable a debug mode in which draw operations to the Guacamole display are highlighted in colored rectangles, where the color varies by the type of operation: * **RED:** Draw of compressed image data (the most expensive operation) * **BLUE:** Copy of existing image data (ie: an optimized scroll, restoring data from a cache - much cheaper than encoding, sending, and decoding image data) * **GREEN:** Solid-color rectangular draw (a combination of `rect` and `cfill` - very cheap). ### Behavior of `guac_common_surface` Here, everything is red. Dirty rects are generally nicely split and tightened around the regions actually changed, but that's about as deep as the processing goes. Without information from the remote desktop server explicitly stating that a particular update is a copy, we can't detect that a copy would be better. https://github.com/apache/guacamole-server/assets/4632905/b0792ae3-f1a7-4bc6-8ce1-932832c32a21 ### Behavior of `guac_display` Now, things get much more colorful. Things that can be represented more efficiently as copies or rectangles are automatically optimized. This includes cases when the nature of those updates would prevent even the remote desktop server from knowing that a copy has occurred. https://github.com/apache/guacamole-server/assets/4632905/6fb37e05-37c3-4eef-ba42-88f4c89442a7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
