necouchman opened a new pull request, #538: URL: https://github.com/apache/guacamole-server/pull/538
This pull request fixes up a couple of issues with public key imports for SSH/SFTP connections: * Adds the required parameters so that public keys can be used for SFTP connections in addition to SSH connections. * Moves the code that checks for the presence of the public key inside the block that checks for private key authentication. I'm still a little fuzzy on the purpose of importing a public key, but, if I understand the libssh2 functions correctly, there's no time that you'd want to try to import or use a public key if you weren't also authenticating with a private key. The code, as merged before, imported the public key regardless of whether a private key was present, and the `if/else` logic use also messed up the detection between public key and password-based authentication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
