jmuehlner commented on code in PR #902:
URL: https://github.com/apache/guacamole-client/pull/902#discussion_r1759564266
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql/conf/PostgreSQLEnvironment.java:
##########
@@ -398,5 +398,17 @@ public boolean enforceAccessWindowsForActiveSessions()
throws GuacamoleException
PostgreSQLGuacamoleProperties.POSTGRESQL_ENFORCE_ACCESS_WINDOWS_FOR_ACTIVE_SESSIONS,
true);
}
+
+ @Override
+ public boolean getCaseSensitiveUsernames() throws GuacamoleException {
+
+ // By default, PostgreSQL does use case-sensitive string searches, so
+ // we will honor case-sensitive usernames.
+ return getProperty(
+
PostgreSQLGuacamoleProperties.POSTGRESQL_CASE_SENSITIVE_USERNAMES,
+ true
Review Comment:
That's a fair point yeah. I'm definitely a fan of not changing behavior
unexpectedly when people upgrade. Backwards compatibility is a good thing to
have. It might just be worth putting a comment here about why this is
defaulting to true instead of false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
