jmuehlner commented on code in PR #1004:
URL: https://github.com/apache/guacamole-client/pull/1004#discussion_r1802135720
##########
guacamole-ext/src/main/java/org/apache/guacamole/token/TokenFilter.java:
##########
@@ -225,15 +225,21 @@ private String filter(String input, boolean strict)
// strict mode is enabled
if (tokenValue == null) {
+ // Token marked as optional, so just skip it and update
+ // last match.
+ if (modifier != null && modifier.equals("OPTIONAL")) {
Review Comment:
I wonder if it's worth putting in a warning if one of the provided tokens
contains `"OPTIONAL"` in it somewhere. There's nothing that would stop a caller
from doing that, and it might cause some unexpected behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
