necouchman commented on PR #1028: URL: https://github.com/apache/guacamole-client/pull/1028#issuecomment-2422300196
> > Otherwise things stop making sense. The JSON auth has a `json-case-sensitive-usernames` property but does not consume external identifiers, so the intent of that property _has_ to be declaring the intent of what other extensions should do with identifiers from JSON auth. For that to be useful, we would need to meaningfully consume `isCaseSensitive()`, but most of the logic around consuming external identifiers on the database side depends solely on the database's `*-case-sensitive-usernames` property. > > I'm starting to thing these changes have part of the right idea, and we need to change the rest to match. > > Yeah, this makes sense to me. I'll review and see what changes need to be made to implement this logic. So, if I'm thinking about this correctly, what this looks like a little more concretely is: * The only reference to the various `Environment` calls for things like `postgresql-case-sensitive-usernames` would be in the JDBC `User` classes, to determine if the `User` identifiers should be treated as case-sensitive. * In all of the various `Service` instances in the JDBC module (e.g. `ModeledDirectoryObjectService`), the call should not be to the `Environment`, but to the `User` object and whether it is case-(in)sensitive. Does that sound right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
