mike-jumper opened a new pull request, #573:
URL: https://github.com/apache/guacamole-server/pull/573
These changes address two issues that were affecting the performance of
Guacamole after the introduction of `guac_display`, particularly RDP:
* The dirty rects of the last frame were not being updated when the
corresponding dirty rects of the pending frame were empty.
It's correct to not flush updated image data if the dirty rects are empty,
but the rects tracking the state of the last frame need to be correctly updated
to match the state of the pending frame, even if that state is empty. Doing
otherwise results in unnecessary updates being transmitted to the client, since
`guac_display` incorrectly believes that things were changed in the last frame.
* Sending a new `sync` for each movement of the mouse can at least cause
client-side slowdowns. There may be things that can be improved in the client.
Opening as a draft for now as that last issue involving `sync` seems to
correlate strongly with our usage of `requestAnimationFrame()`:
* When `window.requestAnimationFrame` has been manually set to `null` via
dev tools, things suddenly become fast.
* If the browser window is in the background (and thus usage of
`requestAnimationFrame()` is disabled), things are also fast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
