eugen-keeper commented on code in PR #1066:
URL: https://github.com/apache/guacamole-client/pull/1066#discussion_r1985463388
##########
guacamole-common-js/src/main/webapp/modules/SessionRecording.js:
##########
@@ -352,11 +381,12 @@ Guacamole.SessionRecording = function
SessionRecording(source, refreshInterval)
*/
var getElementSize = function getElementSize(value) {
- var valueLength = value.length;
-
// Calculate base size, assuming at least one digit, the "."
// separator, and the "," or ";" terminator
- var protocolSize = valueLength + 3;
+ var protocolSize = getUtf8StringByteSize(value) + 3;
+
+ // We need this to calculate the size of the length substring.
+ var valueLength = value.length;
Review Comment:
Good catch! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
