aleitner commented on code in PR #582:
URL: https://github.com/apache/guacamole-server/pull/582#discussion_r2071144471
##########
src/protocols/rdp/settings.c:
##########
@@ -1770,6 +1773,9 @@ void guac_rdp_push_settings(guac_client* client,
/* Explicitly set flag value */
rdp_settings->PerformanceFlags =
guac_rdp_get_performance_flags(guac_settings);
+ /* Set explicit connection type to LAN to prevent auto-detection */
+ freerdp_settings_set_uint32(rdp_settings, FreeRDP_ConnectionType,
CONNECTION_TYPE_LAN);
Review Comment:
I tested with freerdp 2.11.7. I confirmed that `HAVE_SETTERS_GETTERS` is not
defined
`checking whether freerdp_settings_set_pointer is declared... no`
The build succeeded and RDP is working well enough. I only added it for
parity and if I recall the earlier versions of freerdp3 may not have used the
setters and getters just yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
