necouchman commented on code in PR #589:
URL: https://github.com/apache/guacamole-server/pull/589#discussion_r2084814304
##########
src/protocols/kubernetes/settings.c:
##########
@@ -432,14 +432,14 @@ guac_kubernetes_settings*
guac_kubernetes_parse_args(guac_user* user,
/* Use default clipboard buffer size if given one is invalid. */
if (settings->clipboard_buffer_size < GUAC_COMMON_CLIPBOARD_MIN_LENGTH) {
settings->clipboard_buffer_size = GUAC_COMMON_CLIPBOARD_MIN_LENGTH;
- guac_user_log(user, GUAC_LOG_ERROR, "Invalid clipboard buffer "
+ guac_user_log(user, GUAC_LOG_INFO, "Unspecified or invalid clipboard
buffer "
Review Comment:
Is `GUAC_LOG_INFO` really the best? Or is `GUAC_LOG_WARNING` more
appropriate? I'm on the fence, so if you have a reason for using `INFO` vs.
`WARNING`, that's great - just seems to me more like a warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
