mike-jumper commented on PR #597: URL: https://github.com/apache/guacamole-server/pull/597#issuecomment-2945545992
> ... except on lines that have just appeared during a scroll (always at the top or bottom of the screen) ... The top and bottom bounds of the scroll region are actually dynamic and commonly overridden by terminal applications (like text editors) to limit scroll behavior to only a portion of the screen: https://github.com/apache/guacamole-server/blob/cb0aac72ddb98b6dbc5f154397e9b99f6fff9984/src/terminal/terminal/terminal-priv.h#L225-L233 That said, handling this would be tricky, as the status of the terminal state machine (like the scrolling region) is outside the purview of the low-level terminal display, which knows only that basic set of operations like `GUAC_CHAR_SET`, `GUAC_CHAR_COPY`, etc. without context. I'm personally OK with the changes as they stand, though we'll presumably need to make deeper changes in the future to have fully correct behavior. The current approach should satisfy most common usage but I suspect it will not work in some edge cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
