TdlQ commented on PR #1115: URL: https://github.com/apache/guacamole-client/pull/1115#issuecomment-3297085473
I've fixed a few things that you reported. My main focus has been on getSecret() as it required some important changes related to returned values. When the path is wrong, it throws an exception. When the path is good but the secret (key) doesn't exist, it fails silently (well, there is a logger.warn() but the end user won't see it). This is a behaviour borrowed from KSM, I guess it eases exploitation so I kept this way of thinking. Some of your questions still require to be answered but in some cases, I'm not sure what to reply because I blindly followed what was done in the KSM module. I'm a bit out of time but I'll try to do the Jira tasks today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
