dmunozv04 commented on code in PR #1119:
URL: https://github.com/apache/guacamole-client/pull/1119#discussion_r2422787205
##########
Dockerfile:
##########
@@ -99,8 +99,11 @@ USER guacamole
# Environment variable defaults
ENV BAN_ENABLED=true \
ENABLE_FILE_ENVIRONMENT_PROPERTIES=true \
- GUACAMOLE_HOME=/etc/guacamole
+ GUACAMOLE_HOME=/etc/guacamole \
+ HEALTH_CHECK_VALVE_ENABLED=true
# Start Guacamole under Tomcat, listening on 0.0.0.0:8080
EXPOSE 8080
+HEALTHCHECK --interval=60s --timeout=10s --start-period=30s \
+ CMD curl --fail --silent --show-error http://localhost:8080/health || exit
1
Review Comment:
Sounds good to me, I'll implement it soon.
This way the health check will also work if a user changes the
`HEALTH_CHECK_VALVE_PATH` variable to something different than `/health`
Thanks for taking your time to review this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
