necouchman commented on PR #616: URL: https://github.com/apache/guacamole-server/pull/616#issuecomment-3328260280
@liyin398720 There are several issues with this pull request that need to be resolved before we'd consider merging it: * First and most importantly, it builds on work already in progress by @corentin-soriano. I'd highly encourage you to work with Corentin on this effort and either gain his concurrence to continue work on these changes, or, instead, put your work into reviews/comments/changes on his existing pull request (#560). * Assuming you do work with Corentin on this, and he agrees that your pull request should be used, you'll need to clean up the commits quite a bit, particularly the commit messages, which should be descriptive of the reason for the changes. "update log", "add log", etc., are not good commit messages. See: https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/. * At this point, there are also conflicts in pull request that have to be resolved, as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
