eugen-keeper commented on code in PR #608:
URL: https://github.com/apache/guacamole-server/pull/608#discussion_r2376404461
##########
src/terminal/terminal.c:
##########
@@ -504,6 +505,13 @@ guac_terminal* guac_terminal_create(guac_client* client,
/* Configure backspace */
term->backspace = options->backspace;
+ /* Configure the family of codes for function keys and the keypad */
+ if (options->func_keys_and_keypad == NULL ||
options->func_keys_and_keypad[0] == 0) {
+ term->func_keys_and_keypad =
GUAC_TERMINAL_FUNC_KEYS_AND_KEYPAD_DEFAULT;
+ } else if (strcmp(options->func_keys_and_keypad, "vt100plus") == 0) {
Review Comment:
Initially I called the new mode VT100+ because Putty uses the same name. It
is possible they had added + because the original VT100 did not have color
support, then the support was added. Or maybe because the original VT100
keyboard only had 4 function keys but modern keyboard have more function keys.
I think anything we call it can be considered ambiguous. So for now we have the
following names:
GUAC_TERMINAL_FUNC_KEYS_AND_KEYPAD_ESC -> "ESC[n~" (default; same as Putty
has)
GUAC_TERMINAL_FUNC_KEYS_AND_KEYPAD_VT100 -> "vt100" (similar to what we have
for the terminal; although it is important to remember that this is not related
to a terminal type directly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
