necouchman commented on code in PR #1091:
URL: https://github.com/apache/guacamole-client/pull/1091#discussion_r2478102614
##########
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/group/UserGroupService.java:
##########
@@ -227,14 +229,37 @@ public List<Entry>
getParentUserGroupEntries(ConnectedLDAPConfiguration config,
groupAttributes.add(memberAttribute);
// Get all groups the user is a member of starting at the groupBaseDN,
- // excluding guacConfigGroups
+ // excluding guacConfigGroups and evaluating nested groups
+ // (if enabled).
+
+ ExprNode groupFilter = config.getGroupSearchFilter();
+ String filterValue = userIDorDN;
+ final String matchingOID = "1.2.840.113556.1.4.1941";
Review Comment:
I was thinking this would be more appropriate as a class-level variable,
defined as a `public` or `private` `final String` - something like:
`private final String LDAP_GROUP_NESTED_MATCHING_OID =
"1.2.840.113556.1.4.1941";`
defined up in the top section of the class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
