ferman-guzel commented on code in PR #1135:
URL: https://github.com/apache/guacamole-client/pull/1135#discussion_r2602480944
##########
guacamole/src/main/frontend/src/app/settings/services/preferenceService.js:
##########
@@ -133,7 +142,7 @@ angular.module('settings').provider('preferenceService',
['$injector',
*
* @type String
*/
- inputMethod : inputMethods.NONE,
+ inputMethod: inputMethods.TEXT,
Review Comment:
Applied the suggested change
##########
guacamole/src/main/frontend/src/app/settings/services/preferenceService.js:
##########
@@ -168,8 +177,16 @@ angular.module('settings').provider('preferenceService',
['$injector',
// Get stored preferences from localStorage
var storedPreferences =
localStorageServiceProvider.getItem(GUAC_PREFERENCES_STORAGE_KEY);
- if (storedPreferences)
+ if (storedPreferences) {
+ delete storedPreferences.inputMethod;
angular.extend(provider.preferences, storedPreferences);
+ }
+
+ // Load inputMethod from cookie - ONLY READ, DON'T WRITE
+ var cookieInputMethod = getCookie("GUAC_INPUT_METHOD");
+ if (cookieInputMethod) {
+ provider.preferences.inputMethod = cookieInputMethod;
+ }
Review Comment:
Applied the suggested change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
