bbennett-ks commented on code in PR #628:
URL: https://github.com/apache/guacamole-server/pull/628#discussion_r2616081796
##########
src/terminal/terminal.c:
##########
@@ -1451,6 +1451,12 @@ static int __guac_terminal_send_key(guac_terminal* term,
int keysym, int pressed
if ((keysym == 'V' && term->mod_ctrl) || (keysym == 'v' &&
term->mod_meta))
return guac_terminal_send_data(term, term->clipboard->buffer,
term->clipboard->length);
+ /* If Shift+Tab (Backtab), send the appropriate escape sequence */
+ if (term->mod_shift && keysym == 0xFF09) {
+ guac_terminal_send_string(term, "\x1B[Z");
+ return 0;
Review Comment:
Yep, great point. Though currently no functional impact, there could be in
a future redesign.
Your suggestion would be consistent with most (a couple of instances where 0
is returned unconditionally) of the code, though the caller
(guac_terminal_send_key()) return value is currently ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
