bayars commented on code in PR #1149:
URL: https://github.com/apache/guacamole-client/pull/1149#discussion_r2726125643
##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-openid/src/main/java/org/apache/guacamole/auth/openid/conf/ConfigurationService.java:
##########
@@ -429,4 +454,39 @@ public int getMaxNonceValidity() throws GuacamoleException
{
return environment.getProperty(OPENID_MAX_NONCE_VALIDITY,
DEFAULT_MAX_NONCE_VALIDITY);
}
+ /**
+ * Returns the logout endpoint (URI) of the OpenID service, as configured
+ * with guacamole.properties. If configured, users will be redirected to
+ * this endpoint when they log out from Guacamole.
+ *
+ * @return
+ * The logout endpoint of the OpenID service, as configured with
+ * guacamole.properties, or null if not configured.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public URI getLogoutEndpoint() throws GuacamoleException {
+ return environment.getProperty(OPENID_LOGOUT_ENDPOINT);
+ }
+
+ /**
+ * Returns the URI that the OpenID service should redirect to after logout
+ * is complete, as configured with guacamole.properties. If not configured,
+ * the main redirect URI will be used.
+ *
+ * @return
+ * The post-logout redirect URI, as configured with
+ * guacamole.properties, or the main redirect URI if not specified.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public URI getPostLogoutRedirectURI() throws GuacamoleException {
+ URI postLogoutRedirectURI =
environment.getProperty(OPENID_POST_LOGOUT_REDIRECT_URI);
Review Comment:
You're right - getProperty() handles the default value. Pushed the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
