bbennett-ks commented on PR #637:
URL: https://github.com/apache/guacamole-server/pull/637#issuecomment-4384341628

   **Command specified: TERM passed to session.**
   <img width="337" height="867" alt="image" 
src="https://github.com/user-attachments/assets/c7dca914-e5fd-4f33-92ae-1fc88657dfc3";
 />
   
   **Command not specified: TERM not passed  passed to session.**
   <img width="410" height="849" alt="image" 
src="https://github.com/user-attachments/assets/763b8936-8cbe-4bbf-b73a-38e25dd219f8";
 />
   
   I have a UI change that makes option #3 (Set TERM for Exec, and have a note 
that TERM needs to be set manually if Command (exec) is blank) more palatable. 
I've added support for the ability for the protocol Json files to dynamically 
change field labels base on the the value of other fields. e.g. a 
`terminal-type` field label `Terminal type (TERM must be set manually` is 
displayed if `Command (exec):` is empty. 
   
   This done by adding `conditionalLabel` to the field definition, an optional 
condition that allows a field's label to vary based on the value of another 
field (in the same form).
   ```
                   {
                       "name"      : "terminal-type",
                       "type"      : "ENUM",
                       "options"   : [ "", "xterm", "xterm-256color", "vt220", 
"vt100", "ansi", "linux" ],
                       "conditionalLabel" : {
                           "field"    : "exec-command",
                           "equals"   : "",
                           "labelKey" : "FIELD_HEADER_TERMINAL_TYPE_MANUAL_TERM"
                       }
                   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to